Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forward/backward photo navigation using arrow keys #387

Closed
vnugent opened this issue Jun 22, 2022 · 6 comments
Closed

Support forward/backward photo navigation using arrow keys #387

vnugent opened this issue Jun 22, 2022 · 6 comments
Labels
enhancement Improving existing functionality good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@vnugent
Copy link
Contributor

vnugent commented Jun 22, 2022

Use case

In full screen mode I want to jump forward or backward using left and right arrow key.

Use react-hotkeys-hook

Tips:

Screenshot

Screen Shot 2022-06-14 at 5 43 29 PM

@vnugent vnugent added enhancement Improving existing functionality good first issue Good for newcomers help wanted Extra attention is needed labels Jun 22, 2022
@osaf96
Copy link
Contributor

osaf96 commented Jun 28, 2022

@vnugent I would love to take a look at this. Please assign it to me.

@osaf96
Copy link
Contributor

osaf96 commented Jul 13, 2022

sorry, I got a bit busy for a few weeks. I'll quickly try to complete this issue this week hopefully.

@vnugent
Copy link
Contributor Author

vnugent commented Jul 14, 2022

No worries. I updated the original issue to include pointers to the 2 relevant components.

@tedgeving
Copy link
Contributor

tedgeving commented Jan 25, 2023

@vnugent @clinto

I can take a look at this issue if it's still open.

@vnugent vnugent assigned tedgeving and unassigned osaf96 Jan 25, 2023
@vnugent vnugent added this to the v0.7 milestone Jan 25, 2023
@vnugent
Copy link
Contributor Author

vnugent commented Jan 25, 2023

@tedgeving I assigned the issue to you then realized it has been implemented.

If you're still interested in contributing a PR it would be great have a small follow up PR to show some instruction on the side bar. Something like:

Keyboard shortcuts: Previous [ ← ] Next [ → ]
You can use DaisyUI keyboard css classes to style the button.

@tedgeving
Copy link
Contributor

@vnugent I'll take a look at it. Thanks

This was referenced Jan 27, 2023
vnugent added a commit that referenced this issue Feb 1, 2023
* feat(photo): make keyboardTip flag true by default
Co-authored-by: Ted Geving
Co-authored-by: viet nguyen
@vnugent vnugent closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants