fix: Allow identical ticks on one day #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema enforces a unique index on {climbId, dateClimbed, style,
userID, source}. This is meant to prevent duplicating ticks imported
from mountain project. However, it also prevents logging such ticks
when they are legitimate.
The import procedure also deletes imported ticks before reimporting, so
this was overly cautious.
Change the schema so it does not enforce uniqueness in this way.
Instead, add non-unique indexes on { userId } and { userId, climbId }.
Add a db migration script.
Remove climb uniqueness test.
Fixes OpenBeta/open-tacos#631
|
I tried a couple known-problematic logbooks and each worked as expected. |
vnugent
approved these changes
Jul 13, 2023
|
Deployed to staging and production |
|
Did you run the migration? I haven't written one before so if you haven't done it yet, double check the script before you use it! |
Done. Can you try importing again? |
|
It works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema enforces a unique index on {climbId, dateClimbed, style, userID, source}. This is meant to prevent duplicating ticks imported from mountain project. However, it also prevents logging such ticks when they are legitimate.
The import procedure also deletes imported ticks before reimporting, so this was overly cautious.
Change the schema so it does not enforce uniqueness in this way. Instead, add non-unique indexes on { userId } and { userId, climbId }.
Add a db migration script.
Remove climb uniqueness test.
Fixes OpenBeta/open-tacos#631