Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u2 ticklist uses username for tick retrieval #873

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

zichongkao
Copy link
Contributor

@zichongkao zichongkao commented Jun 13, 2023

Based on backend changes here: OpenBeta/openbeta-graphql#313

Intended to fix #864

image

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jun 13, 2023 4:58am

@zichongkao zichongkao requested a review from vnugent June 13, 2023 04:57
@zichongkao zichongkao temporarily deployed to Preview June 13, 2023 04:57 — with GitHub Actions Inactive
@@ -40,7 +39,7 @@ const Tick = (tick: TickType): JSX.Element => {
<a className='hover:underline'>{name}</a>
</Link>
</div>
<div className='text-base-300'>{dateClimbed.toLocaleDateString()}</div>
<div className='text-base-300'>{new Date(dateClimbed).toLocaleDateString()}</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend now returns dateClimbed as a Unix timestamp.

@vnugent vnugent merged commit d13c24f into develop Jun 13, 2023
7 checks passed
@vnugent vnugent deleted the kao-tickusername branch June 13, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View ticks page is broken
2 participants