Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate old profile edit page to react-hook-form #935

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Conversation

vnugent
Copy link
Contributor

@vnugent vnugent commented Jul 25, 2023

What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #811

What this PR achieves

  • chore: retire the old Formik and profile edit page
  • feat: add a new layout to support a more complex account settings
  • chore: add zod form validation library
  • chore: fix/suppress strict type warnings

Note: This PR touches 100 files because Zod requires strict Typescript mode. After turning on strict mode, I decided to fix/suppress all warnings. We'll need to fix all those warnings in the near future.

Screenshots, recordings

Screenshot 2023-07-25 at 9 16 40 PM
Screenshot 2023-07-25 at 9 10 49 PM

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jul 26, 2023 4:19am

chore: new nav screen for update profile
@vnugent vnugent temporarily deployed to Preview July 26, 2023 03:57 — with GitHub Actions Inactive
@vnugent vnugent temporarily deployed to Preview July 26, 2023 04:18 — with GitHub Actions Inactive
@vnugent vnugent merged commit 81900a6 into develop Jul 26, 2023
7 checks passed
@vnugent vnugent deleted the fix-811 branch July 26, 2023 04:26
@vnugent
Copy link
Contributor Author

vnugent commented Jul 30, 2023

@all-contributors add @draykhlin for doc

@allcontributors
Copy link
Contributor

@vnugent

I've put up a pull request to add @draykhlin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant