fix: properly parse VB vscale grades #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncalvinroberts
force-pushed
the
fix-vscale-regex
branch
from
1193754
to
d2d8c40
Compare
musoke
reviewed
Jul 31, 2023
|
Looks good - thank you for the report & fix! @all-contributors add @johncalvinroberts for code and ideas |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @johncalvinroberts! 🎉 |
musoke
approved these changes
Aug 1, 2023
musoke
added a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
musoke
added a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
musoke
added a commit
to OpenBeta/open-tacos
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
6 tasks
vnugent
pushed a commit
to OpenBeta/open-tacos
that referenced
this pull request
Aug 1, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
vnugent
pushed a commit
to OpenBeta/openbeta-graphql
that referenced
this pull request
Aug 3, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
l4u532
pushed a commit
to l4u532/openbeta-graphql
that referenced
this pull request
Aug 23, 2023
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #146