Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability improvements for MacOS event-based backend implementation. #255

Merged
merged 32 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
336d184
Added logs to notify procedure
kdewald Aug 2, 2023
8907d30
WIP
kdewald Aug 2, 2023
6281011
WIP
kdewald Aug 4, 2023
7bcbe85
WIP
kdewald Aug 4, 2023
068fdbe
WIP
kdewald Aug 4, 2023
4156531
WIP
kdewald Aug 4, 2023
1d53433
WIP
kdewald Aug 4, 2023
df90b7e
WIP
kdewald Aug 4, 2023
b7bdbeb
WIP
kdewald Aug 4, 2023
edd180b
WIP
kdewald Aug 4, 2023
6daf1fa
WIP
kdewald Aug 4, 2023
5413f08
WIP
kdewald Aug 4, 2023
d6cdaff
WIP
kdewald Aug 4, 2023
01eb639
WIP
kdewald Aug 4, 2023
fe3455e
Fixed lockup issue, rethinking the rest
kdewald Aug 4, 2023
811e65a
WIP
kdewald Aug 4, 2023
0adaa71
Migrated descriptors to new task structure
kdewald Aug 7, 2023
be6838e
Migrated characteristics to the new task structure
kdewald Aug 7, 2023
b101bb8
Added mutex for BLE operations to guarantee only one operation is hap…
kdewald Aug 7, 2023
b54dc62
Use a single task for characteristic operations.
kdewald Aug 7, 2023
1cba303
Use individual locks for characteristic operations.
kdewald Aug 7, 2023
1c5f870
Moved connection procedure to a single task and lock
kdewald Aug 7, 2023
8c9c65c
Removed old error struct
kdewald Aug 7, 2023
fe2f6a2
Fixed bug in notification-read data handling. More cleanup
kdewald Aug 7, 2023
39e9c8b
Bugfix
kdewald Aug 7, 2023
9c27750
Const
kdewald Aug 7, 2023
296f969
didModifyService also stops current action
kdewald Aug 8, 2023
d5408cd
Copy received NSError
kdewald Aug 9, 2023
595f64f
Rewrote the entire MacOS backend in ObjectiveCpp
kdewald Aug 9, 2023
0cec1f2
Added missing implementation
kdewald Aug 9, 2023
cf0b7c9
Added debug info
kdewald Aug 9, 2023
22331b2
Debugged backend
kdewald Aug 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The format is based on `Keep a Changelog`_, and this project adheres to `Semanti

- (MacOS) Main adapter address is now hardcoded to allow caching based on adapter address. *(Thanks BlissChapman!)*
- (Python) Release GIL when calling ``Peripheral.write_request`` and ``Peripheral.write_command``.
- (MacOS) Operations are now event-based.
- (MacOS) Rewrote the entire backend.
- (MacOS) OperationFailed exception now contains the error message provided by the OS.

**Fixed**
Expand Down
3 changes: 3 additions & 0 deletions simpleble/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,9 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin" OR CMAKE_SYSTEM_NAME STREQUAL "iOS")
set_property(TARGET simpleble PROPERTY INSTALL_RPATH @loader_path)
set_property(TARGET simpleble-c PROPERTY INSTALL_RPATH @loader_path)

# TODO -g3 is only for debugging purposes, remove this later
target_compile_options(simpleble PRIVATE "-g3")

else()
message(FATAL_ERROR "-- [ERROR] UNSUPPORTED SYSTEM: ${CMAKE_HOST_SYSTEM_NAME} ${CMAKE_SYSTEM_NAME}")
endif()
Expand Down
Loading
Loading