Update error handling #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,8 @@ public static function parse_response($response_string, $url, $request_data) | |||
| $response = Util::parse_str($response_string); | |||
|
|
|||
| if ((empty($response['responseEnvelope.ack']) | |||
| OR strpos($response['responseEnvelope.ack'], 'Success') === FALSE)) | |||
| OR strpos($response['responseEnvelope.ack'], 'Success') === FALSE | |||
| OR ! in_array($response['paymentExecStatus'], array('CREATED', 'COMPLETED', 'INCOMPLETE', 'PROCESSING', 'PENDING')))) | |||
There was a problem hiding this comment.
$response['paymentExecStatus'] could be undefined in other API operations. If it's missing, this does not mean the operation was not successful contrary to the acknowledgement field.
Now fails if the payment exec status is not successful status: CREATED COMPLETED INCOMPLETE PROCESSING PENDING Add test
hkdobrev
added a commit
that referenced
this pull request
Feb 6, 2014
Previously we've only checked the acknowledgement field to determine if the operation is successful. [According to the `ExecutePayment` API reference](https://developer.paypal.com/webapps/developer/docs/classic/api/adaptive-payments/ExecutePayment_API_Operation/#id092PA0EE05Z__id092PAL000UI) we must check the `paymentExecStatus` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now fails if the payment exec status is not successful status:
CREATED
COMPLETED
INCOMPLETE
PROCESSING
PENDING
Add test