Iterate arrays when freezing to avoid reference issues #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating an association and perform an action which could access the parent model and then the same association it is accessed by reference and nesting `foreach` loops is causing the internal pointer of the Iterator to move so the outer loop iteration is executed only once. This may cause in multi-brand-purchase scenario, only some of purchase items to be frozen depending on the actions performed by the freeze.
|
LGTM |
hkdobrev
added a commit
that referenced
this pull request
Jun 23, 2015
Iterate arrays when freezing to avoid reference issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating an association and perform an action which could access the parent model and then the same association is accessed by reference and nesting
foreachloops is causing the internal pointer of the Iterator to move so the outer loop iteration is executed only once.This may cause in multi-brand-purchase scenario, only some of purchase items to be frozen depending on the actions performed by the freeze.