Fix width height issues in widgets #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate how we came up with these screen definitions and scattered the parameters around. Any time we have a multi-widget (like LABELVALUERANGEBAR is the worst) it seems like we just picked and chose parameters to pass on to to the sub-widgets. Not sure the best path forward now because it would change screen definitions but this is pretty hard to maintain the way it is. I think we should make certain parameters like WIDTH and HEIGHT only settable via the SETTINGS keyword. |
|
closes #157 |
ryanmelt
requested changes
Nov 16, 2022
| # Create a dot at various y locations. The <%= %> adds the expression to the file | ||
| CANVASDOT 5 <%= 50 * x + 50 %> BLUE 5 | ||
| <% end %> # Close our block from above | ||
| # The code inside is just ruby |
There was a problem hiding this comment.
This comment doesn't make sense anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.