Change include_head to metadata #535
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 73.94% 73.95%
=======================================
Files 459 459
Lines 28442 28442
Branches 600 600
=======================================
+ Hits 21031 21033 +2
+ Misses 7314 7312 -2
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| include_head = params[:include_head].present? ? true : false | ||
| results = bucket.list_files(bucket: bucket_name, path: path, include_head: include_head) | ||
| metadata = params[:metadata].present? ? true : false | ||
| results = bucket.list_files(bucket: bucket_name, path: path, metadata: metadata) |
There was a problem hiding this comment.
The code as-is is currently breaking GCP because gcp_bucket does not have include_head as a parameter. So I changed it to metadata in the latest Enterprise PR because that's really what it is anyway.
I see in #505 that this was just a flag that perhaps they were setting manually so we'll have to give them a heads up. Nothing in our frontend currently uses this option.
|
@wiatrp heads up |
No description provided.