Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ascale parameter #341

Merged
merged 20 commits into from
Apr 4, 2024
Merged

Add ascale parameter #341

merged 20 commits into from
Apr 4, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Feb 5, 2024

Adds an interface to the ascale parameter. Still needs:

  • Tests
  • A tutorial for documentation

Closes #144

It also contains a description for the parameter fixing of the energy calibration, and closes #343

@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 8397044481

Details

  • 36 of 37 (97.3%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/calibrator/momentum.py 14 15 93.33%
Totals Coverage Status
Change from base Build 8391068208: 0.05%
Covered Lines: 6054
Relevant Lines: 6622

💛 - Coveralls

@zain-sohail zain-sohail self-requested a review March 20, 2024 15:42
@rettigl rettigl marked this pull request as ready for review March 22, 2024 21:38
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally and the notebook decribes the process very well. Code looks good to merge.

@rettigl rettigl merged commit 5d9724c into main Apr 4, 2024
6 checks passed
@rettigl rettigl deleted the add_ascale_parameter branch April 4, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants