Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for sp.calibrate_energy_axis #343

Closed
Tommaso-Pincelli opened this issue Feb 15, 2024 · 1 comment · Fixed by #341
Closed

Documentation for sp.calibrate_energy_axis #343

Tommaso-Pincelli opened this issue Feb 15, 2024 · 1 comment · Fixed by #341

Comments

@Tommaso-Pincelli
Copy link

Fitting the energy calibration with the law d^2/(t-t0)^2 is the most appropriate way and leads to the best results.

However, the function is strongly peaked around t0 and can be unstable against initialization parameters (fit might not converge at all).

In sed.calibrate.energy "fit_energy_calibation" this control is actually implemented in a nice way, with a dictionary input to control not just initial value but also min, max and "lock" (whether the parameter is varied or not during the optimization).

It would be of great benefit to the user, and I think a relatively frequent use case, if this was explained in the documentation of sp.calibrate_energy_axis.

@zain-sohail
Copy link
Member

I don't have much experience in calibrating other than the tutorial usage.

It would be great if you could write the short update to doc that you suggested. It can even be in this thread (just a code block/docs of the relevant section)

@rettigl rettigl mentioned this issue Mar 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants