Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugging for parallelized dfield generation #374

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Mar 23, 2024

The parallelization using multiprocessing recently introduced into the dfield generation prevents the code to run in debug mode (it just freezes or gives errors). This PR replaces multiprocessing by joblib to allow debugging of the code
Also, it removes the additional loop parallelization, as it almost does not improve performance, and complicates the code substantially.

remove loop parallelization, as it almost does not improve performance
@coveralls
Copy link
Collaborator

coveralls commented Mar 23, 2024

Pull Request Test Coverage Report for Build 8550711461

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 91.547%

Totals Coverage Status
Change from base Build 8391068208: 0.2%
Covered Lines: 6011
Relevant Lines: 6566

💛 - Coveralls

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There even seems to be an improvement (not sure how reliable) in the benchmark after removal of that extra loop.

@rettigl rettigl merged commit 16dae43 into main Apr 4, 2024
3 checks passed
@rettigl rettigl deleted the parallel_debug_fix branch April 4, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants