Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hextof tutorial missed out changes #471

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

zain-sohail
Copy link
Member

Accidently reverted some changes that needed to be there.

Moreover, using the tutorial beamtime_id now because before it was set to the test data beamtime.

Additionally, the maxwell paths are provided instead of test data paths.

@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9880317245

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.888%

Totals Coverage Status
Change from base Build 9846423405: 0.0%
Covered Lines: 6457
Relevant Lines: 7027

💛 - Coveralls

Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but needs to be rebased. And I suggest to remove the paths in the config/set to empty strings.

sed/config/flash_example_config.yaml Outdated Show resolved Hide resolved
sed/config/flash_example_config.yaml Outdated Show resolved Hide resolved
@zain-sohail zain-sohail merged commit ae221cf into main Jul 11, 2024
6 checks passed
@zain-sohail zain-sohail deleted the update-hextof-tutorial branch July 11, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants