Flash minor changes (Merge to #469) #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10064325275Details
💛 - Coveralls |
rettigl
approved these changes
Jul 18, 2024
| @@ -220,15 +220,16 @@ def get_elapsed_time(self, fids: Sequence[int] = None, **kwds) -> float | list[f | |||
| raise KeyError( | |||
| "File statistics missing. Use 'read_dataframe' first.", | |||
| ) from exc | |||
| time_stamp_alias = self._config["dataframe"].get("time_stamp_alias", "timeStamp") | |||
There was a problem hiding this comment.
`We should add this to the default config. It is also required e.g. in the normalization histogram function for timestamps
| try: | ||
| dtypes[channel] = channels_dict["dldAux"][channel].get("dtype") | ||
| except KeyError: | ||
| dtypes[channel] = None |
There was a problem hiding this comment.
I think it's a bit risky if the data is coerced to 32 without users knowledge. I am not sure if a warning is provided by pandas if the data is float64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor refactoring. Should be merged to fix-459 and then to V1. Mainly: