Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure AUI is included in link of modules #1452

Closed
wants to merge 1 commit into from
Closed

Ensure AUI is included in link of modules #1452

wants to merge 1 commit into from

Conversation

jongough
Copy link
Contributor

Replace deprecated wxWidgets_USE_LIBS with wxWidgets_FIND_COMPONENTS
Ensure build fails if any but webview not found in wxWidgets

@jongough
Ensure AUI is included in link of modules
3ca15a2 
Replace deprecated wxWidgets_USE_LIBS with wxWidgets_FIND_COMPONENTS
Ensure build fails if any but webview not found in wxWidgets
@leamas
Copy link
Collaborator

leamas commented Aug 31, 2019

@nohal @bdbcat : I have looked at this. It actually fixes a bad bug, see discussion in #1446.

@leamas
Copy link
Collaborator

leamas commented Sep 13, 2019

BTW: commit message from #1390:

This is actually a can of worms opened. Part of the problem is the
use of wxWidgets_USE_LIBS instead of wxWidgets_FIND_COMPONENTS which
does not work on modern cmakes, fixed in 1f052c0 but lost when
rebasing a later PR

@rgleason
Copy link
Collaborator

A number of plugins still use wxWidgets_USE_LIBS

leamas added a commit to leamas/radar_pi that referenced this pull request Sep 15, 2019
@leamas
build: Update to recent cmake, mingw fix.
239b56e 
See OpenCPN/OpenCPN#1452
@jongough jongough closed this Dec 26, 2019
@jongough jongough deleted the fix_aui_build_test branch December 26, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jongough @leamas @rgleason