Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the history of a sector, the relationship historic is not correct #4012

Closed
SamuelHassine opened this issue Aug 8, 2023 · 2 comments · Fixed by #4072
Closed

In the history of a sector, the relationship historic is not correct #4012

SamuelHassine opened this issue Aug 8, 2023 · 2 comments · Fixed by #4072
Assignees
@Archidoit
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 5.10.0

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Aug 8, 2023 •
edited

Description

image

Originally:

  • Only contains create / delete of relationships

Even if we would like to display also the modifications of the relationships:

  • Icon is incorrect
  • Message is not clear about which relationship has been modified so most of those messages are useless
@SamuelHassine SamuelHassine added the bug use for describing something not working as expected label Aug 8, 2023
@SamuelHassine SamuelHassine added this to the Release 5.10.0 milestone Aug 8, 2023
@RomuDeuxfois
Copy link
Member

RomuDeuxfois commented Aug 9, 2023 •
edited

Today we have :

For relation

create delete
LinkOutlined LinkOffOutlined

For entity

create merge update && replaces update && changes update && adds update && removes delete
AddOutlined Merge EditOutlined EditOutlined LinkVariantPlus LinkVariantRemove DeleteOutlined

What do we want for the missing cases on relation ?

@RomuDeuxfois RomuDeuxfois added the needs more info Intel needed about the use case label Aug 10, 2023
@Archidoit Archidoit self-assigned this Aug 11, 2023
@Archidoit
Copy link
Member

Archidoit commented Aug 11, 2023 •
edited

Comment: We don't want to display the modifications of relationships, but only the creations and deletions. The issue concerns all the entities (not only sectors).

@Archidoit Archidoit removed the needs more info Intel needed about the use case label Aug 14, 2023
Archidoit added a commit that referenced this issue Aug 14, 2023
@Archidoit
[frontend] entity relations history restriction to creations and dele…
03f2e52 
…tions (#4012)
@Archidoit Archidoit mentioned this issue Aug 14, 2023
Merged
@Archidoit Archidoit linked a pull request Aug 14, 2023 that will close this issue
[frontend] retro compatibility for entities relations histories (#4012) #4072
Merged
Archidoit added a commit that referenced this issue Aug 16, 2023
@Archidoit
[frontend] retro compatibility for entities relations histories (#4012)
b066428
Archidoit added a commit that referenced this issue Aug 16, 2023
@Archidoit
[frontend] retro compatibility for entities relations histories (#4012)
d65bff3
@Archidoit Archidoit added the solved use to identify issue that has been solved (must be linked to the solving PR) label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archidoit Archidoit

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 5.10.0
Development

Successfully merging a pull request may close this issue.

[frontend] retro compatibility for entities relations histories (#4012) OpenCTI-Platform/opencti
3 participants
@SamuelHassine @RomuDeuxfois @Archidoit