Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] retro compatibility for entities relations histories (#4012) #4072

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 14, 2023

issue: #4012

Explanation:
in the history of an entity, the right panel shows the history of the relations of the entity. It should only show creations and deletions (not updates).

New history entities (after june 2023): 'create' or 'delete' is contained in event_scope
old history entities: 'create' or 'delete' is contained in event_type

The modifications here enable to take both new and old history entities into account (retro compatibility)

@Archidoit Archidoit self-assigned this Aug 14, 2023
@Archidoit Archidoit linked an issue Aug 14, 2023 that may be closed by this pull request
@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Aug 14, 2023
@Archidoit Archidoit changed the title [frontend] entity relations history restriction to creations and deletions (#4012) [frontend] retro compatibility for entities relations histories (#4012) Aug 16, 2023
@Archidoit
Copy link
Member Author

PR ready for review

Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for recent history✅
(I cannot test history from before May 2023 because I didn't have any data stored)

Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested locally ✅

@Archidoit Archidoit merged commit d65bff3 into master Aug 16, 2023
6 checks passed
@Archidoit Archidoit deleted the issue/4012 branch August 16, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the history of a sector, the relationship historic is not correct
3 participants