Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick subcription button is not working properly #5963

Closed
SamuelHassine opened this issue Feb 14, 2024 · 2 comments · Fixed by #6002 or #6135
Closed

Quick subcription button is not working properly #5963

SamuelHassine opened this issue Feb 14, 2024 · 2 comments · Fixed by #6002 or #6135
Assignees
@CelineSebe
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.0

Comments

@SamuelHassine
Copy link
Member

Description

  1. Go to a threat actor
  2. Click on the bell

=> The subscription is created but button is not turned to active. Re-clicking do nothing (where it should open a panel). You have to reload the full page.
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Feb 14, 2024
@Archidoit Archidoit mentioned this issue Feb 14, 2024
Closed
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Feb 15, 2024
@CelineSebe CelineSebe self-assigned this Feb 15, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.0 milestone Feb 15, 2024
CelineSebe added a commit that referenced this issue Feb 16, 2024
@CelineSebe
[frontend]Fix quick subscription button(#5963)
46c25af
@CelineSebe CelineSebe mentioned this issue Feb 16, 2024
Merged
5 tasks
@CelineSebe CelineSebe linked a pull request Feb 16, 2024 that will close this issue
[frontend] Fix quick subcription button(#5963) #6002
Merged
5 tasks
CelineSebe added a commit that referenced this issue Feb 20, 2024
@CelineSebe @lndrtrbn @Kedae
[frontend] Fix quick subcription button (#5963)
e1c2692 
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 22, 2024
@nino-filigran nino-filigran reopened this Feb 26, 2024
@nino-filigran nino-filigran removed the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 26, 2024
@nino-filigran
Copy link

@CelineSebe @lndrtrbn & @Kedae there've been a small regression: the bell does not look active, but there is at least a success message. However, the counter of subscriber is not updated, nor the the bell, unless you reload the page (both in testing and demo), hence the reason wh'y I've reopened it.

@Kedae
Copy link
Member

Kedae commented Feb 26, 2024

I'm on it.

@Kedae Kedae mentioned this issue Feb 27, 2024
Merged
Kedae added a commit that referenced this issue Feb 27, 2024
@Kedae
[frontend] Fix the quick Subscription button (#5963)
551e21e
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 27, 2024
Kedae added a commit that referenced this issue Feb 27, 2024
@Kedae
[frontend] linter fix (#5963)
512e506
Kedae added a commit that referenced this issue Feb 27, 2024
@Kedae
[frontend] Linter fix v2 (#5963)
72ae792
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@CelineSebe @lndrtrbn
@Kedae @Archidoit
[frontend] Fix quick subcription button (#5963)
a4df877 
Co-authored-by: Landry Trebon <landry.trebon@filigran.io>
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@Kedae @Archidoit
[frontend] Fix the quick Subscription button (#5963)
60b0408
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@Kedae @Archidoit
[frontend] linter fix (#5963)
c5bb6b4
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@Kedae @Archidoit
[frontend] Linter fix v2 (#5963)
605da64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CelineSebe CelineSebe

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.0
4 participants
@SamuelHassine @Kedae @CelineSebe @nino-filigran