-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix quick subcription button(#5963) #6002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6002 +/- ##
==========================================
+ Coverage 65.44% 67.64% +2.19%
==========================================
Files 539 539
Lines 63055 63568 +513
Branches 5052 6540 +1488
==========================================
+ Hits 41269 43003 +1734
+ Misses 21786 20565 -1221 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check with @Archidoit what was the goal of the previous code
const handleOpen = () => { | ||
searchInstanceTriggers(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kedae this was to update the instance triggers list in case the user had deleted/updated one of triggers via the quick subscription edition panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but seems to work without it now that the 'pagination keys' are the same as Céline told me , strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read wrong Cathia's message, we need to discuss it
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...