Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationships created though inference rules must have the confidence of the Rule Manager user #6093

Closed
labo-flg opened this issue Feb 23, 2024 · 0 comments · Fixed by #6098
Closed

Relationships created though inference rules must have the confidence of the Rule Manager user #6093

labo-flg opened this issue Feb 23, 2024 · 0 comments · Fixed by #6098
Assignees
@labo-flg
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.0

Comments

@labo-flg
Copy link
Member

Description

The Rule Manager user creates relationship according to the inference rules enabled in the platform.
These relationships have a confidence level that is inconsistent across rules, notably by - sometimes - using the average of the confidence of the supporting relationships.

We need to homogenize this computation, by simply using the user's confidence level.
Note that the RULE_MANAGER user has confidence 100 by default.

Environment

5.12.33
@labo-flg labo-flg added bug use for describing something not working as expected inference labels Feb 23, 2024
@labo-flg labo-flg added this to the Release 6.0.0 milestone Feb 23, 2024
@labo-flg labo-flg self-assigned this Feb 23, 2024
labo-flg added a commit that referenced this issue Feb 23, 2024
@labo-flg
[backend] inferred data always have the Rule Manager's confidence (#6093
b03e0b0 
)
@labo-flg labo-flg mentioned this issue Feb 23, 2024
Merged
5 tasks
@richard-julien richard-julien linked a pull request Feb 24, 2024 that will close this issue
[backend] inferred data always have the Rule Manager's confidence (#6093) #6098
Merged
5 tasks
richard-julien added a commit that referenced this issue Feb 24, 2024
@labo-flg @richard-julien
[backend] Inferred data always have the Rule Manager's confidence (#6093
652a633 
)

Co-authored-by: Julien Richard <julien.richard@filigran.io>
@richard-julien richard-julien added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 24, 2024
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@labo-flg @richard-julien @Archidoit
[backend] Inferred data always have the Rule Manager's confidence (#6093
6e59de0 
)

Co-authored-by: Julien Richard <julien.richard@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@labo-flg labo-flg

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.0
Development

Successfully merging a pull request may close this issue.

[backend] inferred data always have the Rule Manager's confidence (#6093) OpenCTI-Platform/opencti
2 participants
@richard-julien @labo-flg