Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] inferred data always have the Rule Manager's confidence (#6093) #6098

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Feb 23, 2024

Proposed changes

  • remove confidence from the rules attribute behavior so it does not get averaged
  • a patch from a rule always end up with confidence equals to the RULE_MANAGER_USER's max confidence level

Related issues

#6093

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@labo-flg labo-flg self-assigned this Feb 23, 2024
@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Feb 23, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (7a75b3a) to head (d021019).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6098      +/-   ##
==========================================
+ Coverage   66.58%   66.68%   +0.10%     
==========================================
  Files         540      540              
  Lines       64270    64268       -2     
  Branches     5223     5267      +44     
==========================================
+ Hits        42791    42859      +68     
+ Misses      21479    21409      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien richard-julien marked this pull request as ready for review February 24, 2024 14:33
@richard-julien richard-julien merged commit 652a633 into master Feb 24, 2024
8 checks passed
@richard-julien richard-julien deleted the issue/6093 branch February 24, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relationships created though inference rules must have the confidence of the Rule Manager user
2 participants