Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle complex paths in stix filtering resolution and use it consistently #6200

Closed
labo-flg opened this issue Mar 1, 2024 · 0 comments · Fixed by #6207
Closed

Handle complex paths in stix filtering resolution and use it consistently #6200

labo-flg opened this issue Mar 1, 2024 · 0 comments · Fixed by #6207
Assignees
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@labo-flg
Copy link
Member

labo-flg commented Mar 1, 2024

This issue is purely technical, and aims at improving our code base reliability and consistency regarding stix object filtering (the internal mechanism we use everywhere, namely the utility function isStixMatchFilterGroup).

in filtering-reosolution.ts:buildResolutionMapForFilter the STIX_RESOLUTION_MAP_PATHS contains mappings between the requested filter key and the key that should be compared in the stix object.

This is very limited, and does not cover the complex case of connectToId filter key, that should search in the stix extension extensions[STIX_EXT_OCTI].id.

1) We need to be able to define complex paths in this mapping

Also, the mapping is not used in the individual testers function, that basically hardcode the same mapping

2) use the mapped (complex) paths in the individual testers for a more robust code

@labo-flg labo-flg added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Mar 1, 2024
@Kedae Kedae added this to the Release 6.0.3 milestone Mar 1, 2024
@Kedae Kedae removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 1, 2024
@Kedae Kedae self-assigned this Mar 1, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants