Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on instance trigger incorrect message when updating the standard Id #6199

Merged
merged 3 commits into from Mar 1, 2024

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Mar 1, 2024

No description provided.

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Mar 1, 2024
@Kedae Kedae requested a review from labo-flg March 1, 2024 10:59
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok

@labo-flg
Copy link
Member

labo-flg commented Mar 1, 2024

For a better solution, let's address #6200

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (997bfac) to head (96a4b19).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6199      +/-   ##
==========================================
+ Coverage   66.68%   66.69%   +0.01%     
==========================================
  Files         541      541              
  Lines       64377    64379       +2     
  Branches     5249     5252       +3     
==========================================
+ Hits        42929    42938       +9     
+ Misses      21448    21441       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit bc8d66e into master Mar 1, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6198 branch March 1, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants