Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinion are not visible anymore #6578

Closed
nino-filigran opened this issue Apr 4, 2024 · 4 comments
Closed

Opinion are not visible anymore #6578

nino-filigran opened this issue Apr 4, 2024 · 4 comments
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@nino-filigran
Copy link

Description

Navigate to a report, there is no opinions. Adding an opinion creates an error message "There are no opinions. You should create some before."

Environment

Testing only (not in demo)

Reproducible Steps

Steps to create the smallest reproducible scenario:
No opinions

  1. Go in a report

Not possible to add an opinion by clicking on CTA

  1. Go in a report
  2. Click on the Thumbs

Expected Output

No opinions
There is an opinion

Not possible to add an opinion by clicking on CTA
open the add an opinion window

Actual Output

No opinions
There is no opinion displayed

Not possible to add an opinion by clicking on CTA
Error message described above

Additional information

Screenshots (optional)

@nino-filigran nino-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Apr 4, 2024
@aHenryJard aHenryJard self-assigned this Apr 4, 2024
@aHenryJard
Copy link
Member

@nino-filigran I think we should change the error message and say that it's a vocabulary that is missing. The actual message is not explicit enough.

@aHenryJard aHenryJard removed their assignment Apr 5, 2024
@nino-filigran
Copy link
Author

nino-filigran commented Apr 5, 2024

Yes that works for me! Something like "The opinions has no value defined in your vocabulary. Please add them first to be able to add opinions"

@SarahBocognano
Copy link
Member

It's working fine on my side on testing

@nino-filigran
Copy link
Author

Yes it works @SarahBocognano since we have added back the opinions manually in Testing, therefore the bug does not happen anymore. In essence it's not a bug, but more the fact that the error message is not clear enough to explain to the user that the vocabulary is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

5 participants