Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] change message if no vocabulary when creating opinion (#6578) #6593

Merged
merged 2 commits into from Apr 5, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Apr 5, 2024

Proposed changes

  • change message if no vocabulary when creating opinion

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marieflorescontact marieflorescontact self-assigned this Apr 5, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Apr 5, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review April 5, 2024 12:12
@Archidoit
Copy link
Member

missing translations

@marieflorescontact
Copy link
Member Author

missing translations

oups. THANKS

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (6b3fe25) to head (b5499b3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6593      +/-   ##
==========================================
+ Coverage   67.78%   67.85%   +0.07%     
==========================================
  Files         532      532              
  Lines       65102    65102              
  Branches     5470     5513      +43     
==========================================
+ Hits        44128    44178      +50     
+ Misses      20974    20924      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit 3596311 into master Apr 5, 2024
5 checks passed
@marieflorescontact marieflorescontact deleted the issue/6578 branch April 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants