Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix cyclic relation bug in tasks and notes #4920

Merged
merged 8 commits into from Nov 28, 2023
Merged

Conversation

Goumies
Copy link
Member

@Goumies Goumies commented Nov 16, 2023

Proposed changes

  • Remove Tasks and Notes from Investigation knowledge based on Container
  • Remove Tasks and Notes from Investigation knowledge to Container

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Goumies Goumies added the filigran team use to identify PR from the Filigran team label Nov 16, 2023
marieflorescontact

This comment was marked as resolved.

@Goumies Goumies force-pushed the issue/4911 branch 3 times, most recently from e49ab57 to d7d0253 Compare November 21, 2023 14:46
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58ae024) 0.00% compared to head (fd00dfd) 87.27%.
Report is 7 commits behind head on master.

❗ Current head fd00dfd differs from pull request most recent head 8fcacbc. Consider uploading reports for the commit 8fcacbc to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4920       +/-   ##
===========================================
+ Coverage        0   87.27%   +87.27%     
===========================================
  Files           0        3        +3     
  Lines           0      220      +220     
  Branches        0       55       +55     
===========================================
+ Hits            0      192      +192     
- Misses          0       28       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Goumies Goumies force-pushed the issue/4911 branch 3 times, most recently from 439f726 to dad3dcb Compare November 23, 2023 09:02
@Goumies Goumies force-pushed the issue/4911 branch 4 times, most recently from ad3b0cb to 51f37cc Compare November 23, 2023 13:58
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested ok 👌

@Goumies Goumies changed the title Fix cyclic relation bug in tasks and notes [backend] Fix cyclic relation bug in tasks and notes Nov 28, 2023
@Goumies Goumies merged commit c187d6a into master Nov 28, 2023
6 checks passed
@Goumies Goumies deleted the issue/4911 branch November 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants