Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency nconf to v0.12.1 #5119

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update dependency nconf to v0.12.1 #5119

merged 2 commits into from
Dec 19, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 5, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nconf 0.12.0 -> 0.12.1 age adoption passing confidence

Release Notes

flatiron/nconf (nconf)

v0.12.1

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies use for pull requests that update a dependency file filigran team use to identify PR from the Filigran team labels Dec 5, 2023
Copy link
Contributor Author

renovate bot commented Dec 5, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: opencti-platform/opencti-graphql/yarn.lock
➤ YN0000: ┌ Resolution step
➤ YN0060: │ opencti-graphql@workspace:. provides graphql (pebcd9) with version 16.8.1, which doesn't satisfy what graphql-import and some of its descendants request
➤ YN0060: │ opencti-graphql@workspace:. provides graphql (p2c3b2) with version 16.8.1, which doesn't satisfy what merge-graphql-schemas and some of its descendants request
➤ YN0002: │ opencti-graphql@workspace:. doesn't provide webpack (p9018d), requested by ts-loader
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 827ms
➤ YN0000: ┌ Fetch step
➤ YN0066: │ nconf@patch:nconf@npm%3A0.12.1#./patch/nconf-0.12.0.patch::version=0.12.1&hash=86f137&locator=opencti-graphql%40workspace%3A.: nconf@patch:nconf@npm%3A0.12.1#./patch/nconf-0.12.0.patch::version=0.12.1&hash=86f137&locator=opencti-graphql%40workspace%3A.: Cannot apply hunk #1 (set enableInlineHunks for details)
➤ YN0013: │ 34 packages were already cached, 4 had to be fetched
➤ YN0000: └ Completed in 5s 433ms
➤ YN0000: Failed with errors in 6s 265ms

Copy link
Contributor Author

renovate bot commented Dec 19, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@labo-flg
Copy link
Member

I removed the patch that we used to make nconf work with esbuild, and switeched back to regular dependency install.

This has been fixed by nconf in the latest version 0.12.1

To test this PR, please yarn install and just try to build and use the platform.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c289afa) 65.60% compared to head (a76a087) 65.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5119   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files         472      472           
  Lines       59160    59160           
  Branches     4328     4329    +1     
=======================================
+ Hits        38811    38813    +2     
+ Misses      20349    20347    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 46c34f9 into master Dec 19, 2023
8 checks passed
@labo-flg labo-flg deleted the renovate/nconf-0.x branch December 19, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies use for pull requests that update a dependency file filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant