Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material-ui monorepo to v5.15.5 #5572

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@mui/icons-material (source) 5.15.4 -> 5.15.5 age adoption passing confidence
@mui/material (source) 5.15.4 -> 5.15.5 age adoption passing confidence
@mui/styles (source) 5.15.4 -> 5.15.5 age adoption passing confidence
@mui/utils (source) 5.15.4 -> 5.15.5 age adoption passing confidence

Release Notes

mui/material-ui (@​mui/icons-material)

v5.15.5

Compare Source

Jan 17, 2024

A big thanks to the 18 contributors who made this release possible. Here are some highlights ✨:

  • Base UI's CSS class prefix is now base- (#​40205) @​michaldudak
  • Bug fixes, and a lot of improvements to code and docs infra
@mui/material@5.15.5
@mui/material-next@6.0.0-alpha.118
@mui/base@5.0.0-beta.32
Breaking changes

The class prefix of Base UI components have been changed from Mui- to base-. This only affects codebases that uses class names verbatim, i.e. not exposed by JS objects such as buttonClasses, but as plain strings or in CSS stylesheets (.MuiButton.root)

To adapt your code to the new pattern:

  • replace all occurrences of the regex .Mui([A-Z][A-Za-z]*)- with .base-$1- (so MuiButton-root becomes base-Button-root, etc.),
  • replace all occurrences of the regex .Mui-([a-z]*) with .base--$1 (so Mui-disabled becomes base--disabled, etc.).
Changes
@mui/joy@5.0.0-beta.23
@mui/codemod@5.15.5
@mui/lab@5.0.0-alpha.161
@mui/material-nextjs@5.15.5
@mui/system@5.15.5
Docs
Core

All contributors of this release in alphabetical order: @​2metres, @​aacevski, @​brijeshb42, @​danilo-leal, @​DiegoAndai, @​josh-feldman, @​Kamino0, @​lhilgert9, @​maakcode, @​michaldudak, @​oliviertassinari, @​petrovmiroslav, @​sai6855, @​samuelsycamore, @​siriwatknp, @​zanivan, @​ZeeshanTamboli, @​zinoroman


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies use for pull requests that update a dependency file filigran team use to identify PR from the Filigran team labels Jan 17, 2024
@SamuelHassine
Copy link
Member

SamuelHassine commented Jan 17, 2024

Be careful, this lib upgrade is breaking the way we are using toggle buttons.

Please fix it before merging (example in ContainerHeader):

image

All left border in buttons are missing, in the first one but also in all middle buttons.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3536586) 66.29% compared to head (966ad58) 66.29%.
Report is 4 commits behind head on master.

❗ Current head 966ad58 differs from pull request most recent head 15e2343. Consider uploading reports for the commit 15e2343 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5572   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files         508      508           
  Lines       59797    59797           
  Branches     4368     4368           
=======================================
+ Hits        39643    39645    +2     
+ Misses      20154    20152    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat self-assigned this Jan 18, 2024
@SouadHadjiat SouadHadjiat self-requested a review January 18, 2024 08:48
@renovate renovate bot force-pushed the renovate/material-ui-monorepo branch from 4a97b2f to 966ad58 Compare January 18, 2024 15:52
@renovate renovate bot force-pushed the renovate/material-ui-monorepo branch from 966ad58 to 15e2343 Compare January 18, 2024 22:14
@SamuelHassine
Copy link
Member

SamuelHassine commented Jan 18, 2024

@SouadHadjiat Thanks a lot for taking a look at the upgrade problem. Unfortunately, since an other merge (x-material-pickers), underlying libraries have been upgraded and the bug is present in the master. I merge this one and open a proper bug here: #5599.

We cannot release the platform with this broken as it leads to a very bad user experience. Appreciate you take a look!

@SamuelHassine SamuelHassine merged commit 717e31a into master Jan 18, 2024
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the renovate/material-ui-monorepo branch January 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies use for pull requests that update a dependency file filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants