Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] add entity_type filter in Victimology tab (#6391) #6397

Merged
merged 3 commits into from Mar 26, 2024
Merged

[frontend] add entity_type filter in Victimology tab (#6391) #6397

merged 3 commits into from Mar 26, 2024

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Mar 20, 2024 •
edited

PR content:

  • add entity_type filter in Victimology tabs
  • fix filters repartition between 'most used filters' and 'all other filters' in filters list in Victimology

issue: #6391

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels Mar 20, 2024
@Archidoit Archidoit self-assigned this Mar 20, 2024
@Archidoit Archidoit linked an issue Mar 20, 2024 that may be closed by this pull request
Several issues in filters of entities' knowledges tab #6391
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.66%. Comparing base (b1ee60f) to head (faa3686).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6397   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files         532      532           
  Lines       64976    64983    +7     
  Branches     5433     5434    +1     
=======================================
+ Hits        43964    43971    +7     
  Misses      21012    21012

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit merged commit ce1dbf9 into master Mar 26, 2024
8 checks passed
@Archidoit Archidoit deleted the issue/6391 branch March 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat left review comments

@SarahBocognano SarahBocognano SarahBocognano approved these changes

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several issues in filters of entities' knowledges tab
3 participants
@Archidoit @SouadHadjiat @SarahBocognano