Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add entity_type filter in Victimology tab (#6391) #6397

Merged
merged 3 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,7 @@ class ListLines extends Component {
availableRelationFilterTypes={availableRelationFilterTypes}
redirection
entityTypes={entityTypes}
restrictedFiltersConfig={{
filterRemoving: additionalFilterKeys,
}}
restrictedFiltersConfig={additionalFilterKeys?.restrictedFiltersConfig ?? undefined}
/>
<ErrorBoundary key={keyword}>
{message && (
Expand Down Expand Up @@ -634,7 +632,7 @@ class ListLines extends Component {
});
availableFilterKeys = uniq(Array.from(filterKeysMap.keys())); // keys of the entity type if availableFilterKeys is not specified
}
if (additionalFilterKeys) availableFilterKeys = availableFilterKeys.concat(additionalFilterKeys);
if (additionalFilterKeys) availableFilterKeys = uniq(availableFilterKeys.concat(additionalFilterKeys.filterKeys));
if (disableExport) {
return this.renderContent(availableFilterKeys, entityTypes);
}
Expand Down Expand Up @@ -700,7 +698,7 @@ ListLines.propTypes = {
handleExportCsv: PropTypes.func,
helpers: PropTypes.object,
availableFilterKeys: PropTypes.array,
additionalFilterKeys: PropTypes.array,
additionalFilterKeys: PropTypes.object,
entityTypes: PropTypes.array,
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ const ListFilters = ({
? availableFilterKeys
.map((key) => {
const subEntityTypes = filterKeysMap.get(key)?.subEntityTypes ?? [];
const isFilterKeyForAllTypes = subEntityTypes.some((subType) => entityTypes.includes(subType));
const isFilterKeyForAllTypes = (entityTypes.length === 1 && subEntityTypes.some((subType) => entityTypes.includes(subType)))
Archidoit marked this conversation as resolved.
Show resolved Hide resolved
|| (entityTypes.length > 1 && entityTypes.every((subType) => subEntityTypes.includes(subType)));
return {
value: key,
label: t_i18n(filterKeysMap.get(key)?.label ?? key),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ const StixCoreRelationshipCreationFromEntity: FunctionComponent<StixCoreRelation
availableEntityTypes={virtualEntityTypes}
handleToggleSelectAll="no"
entityTypes={virtualEntityTypes}
additionalFilterKeys={['entity_type']}
additionalFilterKeys={{ filterKeys: ['entity_type'], restrictedFiltersConfig: { filterRemoving: ['entity_type'] } }}
>
<QueryRenderer
query={stixCoreRelationshipCreationFromEntityStixCoreObjectsLinesQuery}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ EntityStixCoreRelationshipsEntitiesViewProps

// Filters due to screen context
const userFilters = useRemoveIdAndIncorrectKeysFromFilterGroupObject(filters, stixCoreObjectTypes.length > 0 ? stixCoreObjectTypes : ['Stix-Core-Object']);
const stixCoreObjectFilter: Filter[] = stixCoreObjectTypes.length > 0 ? [{ key: 'entity_type', operator: 'eq', mode: 'or', values: stixCoreObjectTypes }] : [];
const stixCoreObjectFilter: Filter[] = stixCoreObjectTypes.length > 0
? [{ key: 'entity_type', operator: 'eq', mode: 'or', values: stixCoreObjectTypes }]
: [];
const contextFilters: FilterGroup = {
mode: 'and',
filters: [
Expand Down Expand Up @@ -203,6 +205,7 @@ EntityStixCoreRelationshipsEntitiesViewProps
enableContextualView={enableContextualView}
currentView={finalView}
entityTypes={stixCoreObjectTypes.length > 0 ? stixCoreObjectTypes : ['Stix-Core-Object']}
additionalFilterKeys={{ filterKeys: ['entity_type'] }}
>
<EntityStixCoreRelationshipsEntitiesViewLines
paginationOptions={paginationOptions}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ class StixDomainObjectVictimology extends Component {
{viewMode === 'nested' && (
<QueryRenderer
query={
stixDomainObjectVictimologySectorsStixCoreRelationshipsQuery
}
stixDomainObjectVictimologySectorsStixCoreRelationshipsQuery
}
variables={{ first: 500, ...paginationOptionsSectors }}
render={({ props }) => {
if (props) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -627,14 +627,32 @@ export const getAvailableOperatorForFilter = (

export const useBuildFilterKeysMapFromEntityType = (entityTypes = ['Stix-Core-Object']): Map<string, FilterDefinition> => {
const { filterKeysSchema } = useAuth().schema;
// 1. case one entity type
if (entityTypes.length === 1) {
return filterKeysSchema.get(entityTypes[0]) ?? new Map();
}
// 2. case several entity types
const filterKeysMap = new Map();
entityTypes.forEach((entityType) => {
const currentMap = filterKeysSchema.get(entityType);
currentMap?.forEach((value, key) => filterKeysMap.set(key, value));
currentMap?.forEach((value, key) => {
if (filterKeysMap.has(key)) { // add entity type in subEntityTypes of the filter definition
filterKeysMap.set(key, { ...value, subEntityTypes: filterKeysMap.get(key).subEntityTypes.concat([entityType]) });
} else { // add the filter definition in the map
filterKeysMap.set(key, value);
}
});
});
if (entityTypes.length > 0) { // add entity_type filter if several types are given (entity_type filter already present for abstract types)
filterKeysMap.set('entity_type', {
filterKey: 'entity_type',
type: 'string',
label: 'Entity type',
multiple: true,
subEntityTypes: entityTypes,
elementsForFilterValuesSearch: [],
});
}
return filterKeysMap;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ import {
ENTITY_TYPE_CONTAINER_OPINION,
ENTITY_TYPE_CONTAINER_REPORT,
ENTITY_TYPE_COURSE_OF_ACTION,
ENTITY_TYPE_IDENTITY_INDIVIDUAL,
ENTITY_TYPE_IDENTITY_SECTOR,
ENTITY_TYPE_IDENTITY_SYSTEM,
ENTITY_TYPE_INCIDENT,
ENTITY_TYPE_INFRASTRUCTURE,
ENTITY_TYPE_INTRUSION_SET,
Expand Down Expand Up @@ -64,6 +67,10 @@ schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_COURSE_OF_ACTION,
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_CONTAINER_GROUPING, [objectOrganization]);
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_VULNERABILITY, [objectOrganization]);

schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_SYSTEM, []);
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_SECTOR, []);
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_IDENTITY_INDIVIDUAL, []);

schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_LOCATION_REGION, []);
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_LOCATION_CITY, []);
schemaRelationsRefDefinition.registerRelationsRef(ENTITY_TYPE_LOCATION_COUNTRY, []);
Expand Down