Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make genXrdPattern a git submodule #1186

Closed
yurivict opened this issue Oct 16, 2022 · 1 comment
Closed

Please make genXrdPattern a git submodule #1186

yurivict opened this issue Oct 16, 2022 · 1 comment
Assignees
@cryos

Comments

@yurivict
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Downloading files during build isn't supported by package managers for security reasons.
There is git submodule mechanism that should be used instead, that pre-downloads required files.

Describe the solution you'd like
See subject.

The VTK option can't be made default because of this problem.

FreeBSD 13.1 STABLE
cryos added a commit to cryos/avogadrolibs that referenced this issue Apr 16, 2023
@cryos
Advanced option to use the system generateXrd
23790eb 
We shouldn't download things during build by default. Ideally this would
get packaged or added as a step in the superbuild. Fixes issue OpenChemistry#1186 by
defaulting to expect a system binary.

Signed-off-by: Marcus D. Hanwell <marcus@cryos.net>
@cryos cryos mentioned this issue Apr 16, 2023
Merged
@cryos cryos self-assigned this Apr 16, 2023
@cryos
Copy link
Member

cryos commented Apr 16, 2023

The binary is independent of the project, I never really liked the default download of a static binary as part of our build process. Defaulting it to off, and then our build process can turn it on if we prefer, as can developers. I think this is reasonable, we use submodules in the supoerbuild where it could move, but this is just static binaries, so not sure if that is aided with a submodule in this case.

@cryos cryos closed this as completed Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryos cryos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cryos @yurivict