Use explicit conversion to QString (needed to compile Kalzium without removing -DQT_RESTRICTED_CAST_FROM_ASCII) #414
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines and check for the automated tests. |
There was a problem hiding this comment.
Why is "-DQT_RESTRICTED_CAST_FROM_ASCII" needed/used in Kalzium? I think we use this in a few places, and wasn't aware of issues doing it. It would be good to understand the reasoning - is there a link to any further explanation on why you wouldn't allow the cast?
|
Oops... My bad. To port Kalzium to KF5/Qt5 I firstly used more strict rules that were committed by other developers https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEFrameworkCompilerSettings.cmake and that was the only place that does not allow libscience to compile. But the rules are too strict as it seems. So I switched to https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDECompilerSettings.cmake forgetting to test if it works without changing libavogadro. Now I have tested this and it works without altering libavogadro code. Sorry for your time. :'( |
|
No worries - we’d rather have issues reported than to have something missing! Thanks! |
|
As Geoff said no worries, I was more interested in the underlying reason as I make calls like this in a number of pure C++ API interfacing with Qt APIs. I appreciate you taking a second look. |
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.