Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new --noh flag in Open Babel 3.0.1 and later #471

Merged
merged 4 commits into from
May 8, 2020

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented May 2, 2020

Ensures hydrogens are not added automatically.
Fixes #442 (and probably other issues)

Signed-off-by: Geoff Hutchison geoff.hutchison@gmail.com

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Ensures hydrogens are not added automatically.
Fixes OpenChemistry#442 (and probably other issues)

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis
Copy link
Member Author

ghutchis commented May 2, 2020

This will require a bump for openbabel-3-0-1 or at least openbabel/openbabel@4b228ac

OTOH, it will greatly help with several complaints (e.g. Open Babel automatically adding hydrogen atoms).

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@cryos
Copy link
Member

cryos commented May 2, 2020

We will need to get the superbuild updated, I was hoping to look at some reported failure to optimize geometry on macOS - does this work for you @ghutchis with the superbuild?

@ghutchis
Copy link
Member Author

ghutchis commented May 2, 2020

It works with the "system" Open Babel installed from master - we should be tagging that release ASAP.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis
Copy link
Member Author

ghutchis commented May 2, 2020

I'm still testing the molecules from Geoff Clark - seem to be different issues - that's not fixed yet.

@ghutchis
Copy link
Member Author

ghutchis commented May 2, 2020

The issue from Geoff Clark is #473 - the files are too big for Avogadro's MDL format code which silently causes problems.

Should solve problems with large molecules

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis
Copy link
Member Author

ghutchis commented May 6, 2020

@cryos - now that Open Babel 3.1 is merged, we should be able to merge this.

@ghutchis ghutchis merged commit e169315 into OpenChemistry:master May 8, 2020
@ghutchis ghutchis deleted the noh-ob-301 branch May 8, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Babel Optimize Geometry arbitrarily adds H atoms
2 participants