Save the description.json alongside the script #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user clicks the "Save Script" button below an operator's python script, and then chooses to save the script somewhere, save the description.json file next to it (where the filename will be the script name with a `.json` extension) it if the following conditions are true: 1. The JSON description for the operator is not empty 2. The file does not already exist 3. We have permission to write the file Maybe we can discuss this logic... Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This will hide the "Additional Parameters" for the reconstruction section if, for instance, a parameter with a test rotations tag is present. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
added a commit
to psavery/tomvizdocs
that referenced
this pull request
Oct 11, 2021
This adds documentation for both running the `FXI Workflow` operator, and adding extra parameters to the `FXI Workflow` operator. Depends on: OpenChemistry/tomviz#2201 Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Just to make it much clearer what is going on, if the description file exists, ask the user if they want to overwrite it. This will make things much more intuitive as to when the file gets overwritten. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
cjh1
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user clicks the "Save Script" button below an operator's
python script, and then chooses to save the script somewhere,
save the description.json file next to it (where the filename will be
the script name with a
.jsonextension) it if the following conditionsare true: