Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the description.json alongside the script #2201

Merged
merged 3 commits into from
Oct 11, 2021

Commits on Oct 8, 2021

  1. Save the description.json alongside the script

    If the user clicks the "Save Script" button below an operator's
    python script, and then chooses to save the script somewhere,
    save the description.json file next to it (where the filename will be
    the script name with a `.json` extension) it if the following conditions
    are true:
    
    1. The JSON description for the operator is not empty
    2. The file does not already exist
    3. We have permission to write the file
    
    Maybe we can discuss this logic...
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    870a265 View commit details
    Browse the repository at this point in the history
  2. Hide recon "Additional Params" for wrong tags

    This will hide the "Additional Parameters" for the reconstruction
    section if, for instance, a parameter with a test rotations tag is
    present.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3cd7472 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. If description exists, ask user to overwrite it

    Just to make it much clearer what is going on, if the description
    file exists, ask the user if they want to overwrite it. This will
    make things much more intuitive as to when the file gets overwritten.
    
    Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
    psavery committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    dd65681 View commit details
    Browse the repository at this point in the history