Override qSetMessagePattern in tomviz #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParaView sets this in the pqOutputWidget [here](https://gitlab.kitware.com/paraview/paraview/-/blob/eda557d7ad642027943b8c721c85173b35b2f6a4/Qt/Core/pqOutputWidget.cxx#L410). However, in our tomviz dev build, it never prints out any meaningful information for the file and line number, perhaps because our dev environment uses "RelWithDebInfo". Typically, we just get a whole bunch of extra messages that look like this: ``` debug: In unknown, line 0 ``` Override `qSetMessagePattern` after our `pqOutputWidget` has been constructed so our debug output doesn't get flooded with meaningless messages. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
cjh1
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParaView sets this in the pqOutputWidget here.
However, in our tomviz dev build, it never prints out any meaningful
information for the file and line number, perhaps because our dev
environment uses "RelWithDebInfo". Typically, we just get a whole bunch
of extra messages that look like this:
Override
qSetMessagePatternafter ourpqOutputWidgethas beenconstructed so our debug output doesn't get flooded with meaningless
messages.