-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CombineBridge): Draft implementation #218
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 97.73% 95.60% -2.14%
==========================================
Files 100 109 +9
Lines 6946 7101 +155
==========================================
Hits 6789 6789
- Misses 157 312 +155
Continue to review full report at Codecov.
|
init(_ combineIdentifier: OpenCombine.CombineIdentifier) { | ||
self.init(rawValue: _rawValue(for: combineIdentifier)) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Lines should not have trailing whitespace. (
trailing_whitespace
)
as: Combine.CombineIdentifier() | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Lines should not have trailing whitespace. (
trailing_whitespace
)
public typealias Failure = Subject.Failure | ||
|
||
public func receive<S>(subscriber: S) | ||
where S: OpenCombine.Subscriber, Subject.Failure == S.Failure, Subject.Output == S.Input { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Line should be 90 characters or less: currently 92 characters (
line_length
)
public var combineIdentifier: OpenCombine.CombineIdentifier { | ||
subscriber.combineIdentifier.ocombine | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Lines should not have trailing whitespace. (
trailing_whitespace
)
It's a draft implementation for #217
Notes:
rawValues
fromSubscribers.Demand
andCombineIdentifier
and to create new ones with the same underlying value, so the implementation relies onCombine
's private APIsmaster
, most of the modern projects usemain
already, maybe it worth renamingmaster
tomain
🌚