Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/collection summaries show zero results if the actual summary isn't available #1179

Closed
paynejd opened this issue Jan 5, 2022 · 1 comment
Closed

source/collection summaries show zero results if the actual summary isn't available #1179

paynejd opened this issue Jan 5, 2022 · 1 comment
Assignees
@snyaggarwal
Labels
api2 OCL API v2 web2 OCL WEB v2

Comments

@paynejd
Copy link
Member

paynejd commented Jan 5, 2022

If a summary for a source/collection version isn't yet available, the TermBrowser displays that there are zero concepts/mappings and one version, which is incorrect -- it should instead display something to indicate that the summary is not yet available/is being loaded/etc.

See screenshot below:
image
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Jan 6, 2022
@snyaggarwal
OpenConceptLab/ocl_issues#1179 | source/collection | active concepts/…
97362cd 
…mappings counts to be None when not set rather than 0
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Jan 6, 2022
@snyaggarwal
OpenConceptLab/ocl_issues#1179 | source/collection | active concepts/…
e1315ff 
…mappings show unset indicator
@snyaggarwal snyaggarwal added api2 OCL API v2 web2 OCL WEB v2 labels Jan 6, 2022
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Jan 7, 2022
@snyaggarwal
OpenConceptLab/ocl_issues#1179 | fixing test
45ad4dc
@snyaggarwal
Copy link
Contributor

This is done and deployed on all environments. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snyaggarwal snyaggarwal

Labels
api2 OCL API v2 web2 OCL WEB v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paynejd @snyaggarwal