"Add as Expression" button

[jamlung-ri]

Following up on #1187, there is one more powerful feature that would help users to manage collections using our Dynamic References features.

When using the Add References feature, a user could do a search (maybe with one or more filters) and select all concepts with the intent of adding a single, powerful expression rather than individual expressions. A user should essentially be able to take the search query, filters, etc. or the source/collection in view and, rather than creating individual expressions, can add the query as a single reference.

Worth noting that we can already add these expressions using the Add Expressions tab, but this would help users to construct these queries easier.

[paynejd]

A first step might be for a user to be able to optionally view the query expression that the TermBrowser constructed based on their search. Once we're happy with that, then we could add actions around it -- e.g. copy, save search, add as expression, etc.

…

On Wed, Jan 26, 2022 at 12:16 PM Joseph Amlung ***@***.***> wrote: Following up on #1187 <#1187>, there is one more powerful feature that would help users to manage collections using our Dynamic References features. When using the Add References feature, a user could do a search (maybe with one or more filters) and select all concepts with the intent of adding a single, powerful expression rather than individual expressions. A user should essentially be able to take the search query, filters, etc. or the source/collection in view and, rather than creating individual expressions, can add the query as a single reference. Worth noting that we can already add these expressions using the Add Expressions tab, but this would help users to construct these queries easier. — Reply to this email directly, view it on GitHub <#1191>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJCOOKUGUW6637V7AZBPGDUYAUAHANCNFSM5M3TUCVA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jamlung-ri]

There is a little more to do with this, which we noted in the Arch call from 1/28/2022

[snyaggarwal]

@jamlung-ri This should be deployed on QA

[jamlung-ri]

Looks like there are some bugs, and we can probably reword the buttons a little bit.

Bugs:

• Add as expression does not seem to be working when I first access the page i.e. no filters applied. It lets me go through the Add Mappings prompt, but then it just spins and is never able to add the reference. It eventually gives a 504 Gateway Timeout. Once I applied a filter, however, I was able to add the expression.
  

• I was also unable to Add Selected concepts. Not sure why, but it just spins on this screen, with no prompts about Adding Mappings. It also eventually gives a 504 Gateway Timeout.
  

Button rewording and behavior change:
I think it might make more sense if the button works more like this, although we can refine it to whatever makes the most sense.

In this case, if no concepts are selected, then the "Add selected concepts" option would be disabled and greyed out. If concepts are selected (and there is no available expression), then the "Add expression" option would be disabled.

[snyaggarwal]

@jamlung-ri This should all be fixed on QA

[jamlung-ri]

Cool! One more thing:

• Implement the same Add as Expression button into the "Find a Source/Collection". This would allow a user to add an expression to get all concepts or mappings from a particular source or collection. This might need something to allow the user to decide whether to add a reference for concepts only, for mappings only, or for both (maybe using a nested dropdown list?).
  
  Example nested list:
  

[snyaggarwal]

@jamlung-ri this is deployed on QA

[jamlung-ri]

This is working well! One quick question: should this popup be appearing when adding an expression? I don't think it actually adds mappings, even if the boxes are checked.

[snyaggarwal]

@jamlung-ri this is something we have to discuss, ideally with any expression we should/may have $cascade clubbed

[snyaggarwal]

@jamlung-ri Can this be closed?

[jamlung-ri]

I think so, We can do a follow-up ticket if needed for the expression $cascade.