Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Import Issue - retired:FALSE is not valid? #1272

Closed
jamlung-ri opened this issue Apr 7, 2022 · 3 comments
Closed

CSV Import Issue - retired:FALSE is not valid? #1272

jamlung-ri opened this issue Apr 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jamlung-ri
Copy link
Contributor

I noticed that when bulk importing a CSV file using the Bulk Import Interface, the retired field was causing it to fail because the casing was FALSE instead of False. Note that Excel seems to default the value to FALSE in its CSV files, so I'm hoping we can fix the bulk importer to be able to accept FALSE in boolean fields.

Example CSV file where concepts fail to import: https://drive.google.com/file/d/1lmK0qDlDJU4Mth__gCeSkPkiON0c0I02/view

@jamlung-ri jamlung-ri added the bug Something isn't working label Apr 7, 2022
snyaggarwal added a commit to OpenConceptLab/ocldev that referenced this issue Apr 8, 2022
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Apr 8, 2022
@snyaggarwal
Copy link
Contributor

@jamlung-ri Added missing datatype bool in ocldev concept definition retired attribute.
Added an integration test for this as well.
@paynejd Can you please release a new version for ocldev.
@jamlung-ri You can test this out on QA.

@jamlung-ri
Copy link
Contributor Author

This is working well in QA! Bulk import with retired:FALSE values worked well.

@paynejd
Copy link
Member

paynejd commented Apr 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants