Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create released CIEL source version with QA/Demo deployments #148

Closed
paynejd opened this issue Aug 28, 2019 · 10 comments
Closed
Assignees
Labels
affects-ocl-client Issues directly impacting the OCL Client(https://github.com/openmrs/openmrs-ocl-client/) openmrs

Comments

@paynejd
Copy link
Member

paynejd commented Aug 28, 2019

We need to automatically create a source version with "released": True when we redeploy to QA and demo. So, after the CIEL dictionary is imported, run the request below. Second, the date (and hence the ID/description) for the source version will of course change as we update the CIEL dictionary.

POST /orgs/CIEL/sources/CIEL/versions/

{
    "id": "v2018-06-01",
    "released": true,
    "description": "CIEL release v2018-06-01",
}
@karuhanga
Copy link
Collaborator

@paynejd would it have been possible to deploy an already released CIEL version?

@cantwi2019
Copy link

What is the status of this ticket? when can we expect it to be completed?

@paynejd
Copy link
Member Author

paynejd commented Sep 19, 2019

@rkorytkowski it looks like QA might have been redeployed and there are now no released versions of CIEL. Could you verify which CIEL version is on QA? Is it possible to automatically create a released version of CIEL upon redeployment?

@rkorytkowski
Copy link
Contributor

rkorytkowski commented Sep 19, 2019

QA does have the latest CIEL version (2k subset), however it is not automatically released when redeployed. I can implement that tomorrow.

@karuhanga
Copy link
Collaborator

@rkorytkowski Kindly let us know when you manage to. Thank you.

rkorytkowski added a commit to OpenConceptLab/oclapi that referenced this issue Sep 23, 2019
rkorytkowski added a commit to OpenConceptLab/oclapi that referenced this issue Sep 23, 2019
rkorytkowski added a commit to OpenConceptLab/oclapi that referenced this issue Sep 23, 2019
rkorytkowski added a commit to OpenConceptLab/oclapi that referenced this issue Sep 23, 2019
@paynejd
Copy link
Member Author

paynejd commented Sep 23, 2019 via email

@rkorytkowski
Copy link
Contributor

The fix is in place. The export is downloadable, however, there's some issue with concepts/mappings not being properly listed for a new version on the details page. I'll address ASAP.

karuhanga added a commit to OpenConceptLab/oclapi that referenced this issue Oct 6, 2019
…rce version with QA/Demo deployments

- Create a 'released' version
@karuhanga
Copy link
Collaborator

karuhanga commented Oct 6, 2019

there's some issue with concepts/mappings not being properly listed for a new version on the details page.

@rkorytkowski any progress on this?

Currently this;
https://api.qa.openconceptlab.org/orgs/CIEL/sources/CIEL/concepts/

and this;
https://api.qa.openconceptlab.org/orgs/CIEL/sources/CIEL/latest/concepts/

return significantly different data.

@karuhanga karuhanga added the affects-ocl-client Issues directly impacting the OCL Client(https://github.com/openmrs/openmrs-ocl-client/) label Oct 8, 2019
@karuhanga
Copy link
Collaborator

This(OpenConceptLab/oclapi@2d365ba) should address the auto release.

@karuhanga
Copy link
Collaborator

karuhanga commented Oct 9, 2019

Currently this;
https://api.qa.openconceptlab.org/orgs/CIEL/sources/CIEL/concepts/
and this;
https://api.qa.openconceptlab.org/orgs/CIEL/sources/CIEL/latest/concepts/
return significantly different data.

So I think this was down to the update not being triggered. This(OpenConceptLab/oclapi@7e6684b) should address that.

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-ocl-client Issues directly impacting the OCL Client(https://github.com/openmrs/openmrs-ocl-client/) openmrs
Projects
None yet
Development

No branches or pull requests

5 participants