Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting mappings from API v2 slow to respond #553

Closed
bmamlin opened this issue Jan 26, 2021 · 6 comments
Closed

Requesting mappings from API v2 slow to respond #553

bmamlin opened this issue Jan 26, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@bmamlin
Copy link

bmamlin commented Jan 26, 2021

Some mapping requests to API v2 are slow to respond.

Example

GET https://api.qa.aws.openconceptlab.org/orgs/CIEL/sources/CIEL/mappings/?fromConcept=1067,162625,1065&limit=0

Observed Behavior

Response time is currently ~16 seconds. The same request in API v1 responds in ~300 ms.

Expected Behavior

Response time less than 300 ms.

@bmamlin bmamlin added the bug Something isn't working label Jan 26, 2021
@snyaggarwal
Copy link
Contributor

@bmamlin
Copy link
Author

bmamlin commented Jan 27, 2021

Adding the &q= to the end makes it work (quick response with expected results). It looks like omitting &q= not only makes the response incredibly slow, but returns seemingly random results (e.g., ?fromConcept=1226&limit=0 eventually returns ~25 seemingly random results with from_concept_code something other than 1226 in most cases instead of – with &q= added – instantly responding with the 6 mappings from CIEL 1226).

Can you make the omission of &q= behave the same as having it there?

@snyaggarwal
Copy link
Contributor

yes. Just working on that only. Should be available after the next deployment today.

@snyaggarwal
Copy link
Contributor

@snyaggarwal
Copy link
Contributor

@bmamlin Let me know if this can be closed.

@paynejd
Copy link
Member

paynejd commented Jan 27, 2021

tested - looking good!

@paynejd paynejd closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants