Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oclapi2] [bug] [ES] Resources with extras schema different from other not indexed. #637

Closed
snyaggarwal opened this issue Mar 12, 2021 · 4 comments
Closed

[oclapi2] [bug] [ES] Resources with extras schema different from other not indexed. #637

snyaggarwal opened this issue Mar 12, 2021 · 4 comments
Assignees
@paynejd @snyaggarwal @jamlung-ri
Labels
bug Something isn't working
Milestone
Sprint 6

Comments

@snyaggarwal
Copy link
Contributor

elastic/elasticsearch-dsl-py#1492
@snyaggarwal snyaggarwal added this to the Sprint 6 milestone Mar 12, 2021
@snyaggarwal snyaggarwal self-assigned this Mar 12, 2021
@snyaggarwal snyaggarwal added the bug Something isn't working label Mar 15, 2021
snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Mar 17, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#637 | flatten extras to separate fields for…
a9d6325 
… indexing
@snyaggarwal
Copy link
Contributor Author

@paynejd @rkorytkowski @jamlung-ri As per our discussion in the last dev call, the exact fields are flattened and converted to strings. (Reindexing running in QA/Staging at the time of writing this)

The queries have changed a bit: (notice the double underscore __)
?extras.exists=questionnaire_choice_value.code --> ?extras.exists=questionnaire_choice_value__code
?extras.exact.questionnaire_choice_value.code=foobar --> ?extras.exact.questionnaire_choice_value__code=foobar
?extras.questionnaire_choice_value.code=foobar --> ?extras.questionnaire_choice_value__code=foobar

@snyaggarwal snyaggarwal mentioned this issue Mar 17, 2021
Closed
@paynejd
Copy link
Member

paynejd commented Mar 18, 2021

@jamlung-ri @paynejd
The new syntax requires changes to MSP and PEPFAR integration scripts. Added to architecture call for discussion

@snyaggarwal
Copy link
Contributor Author

@paynejd @jamlung-ri
fixed the syntax --
Both works now . and __, so ideally now you dont have to change anything in the scripts. Examples:
?extras.exists=questionnaire_choice_value.code & ?extras.exists=questionnaire_choice_value__code
?extras.exact.questionnaire_choice_value.code=foobar & ?extras.exact.questionnaire_choice_value__code=foobar
?extras.questionnaire_choice_value.code=foobar & ?extras.questionnaire_choice_value__code=foobar

snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Mar 25, 2021
@snyaggarwal
OpenConceptLab/ocl_issues#637 | extras query supports __ or . for nes…
ae78e4b 
…ted query
@jamlung-ri
Copy link
Contributor

Will create a follow-up ticket for testing in case issues come up from this.

@jamlung-ri jamlung-ri mentioned this issue Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paynejd paynejd

@snyaggarwal snyaggarwal

@jamlung-ri jamlung-ri

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 6
Development

No branches or pull requests
3 participants
@paynejd @snyaggarwal @jamlung-ri