Need ability to delete an existing source that other sources/collections are referencing

[paynejd]

Specifically, we are getting ready for when we will delete the PIH source on staging

Will also need to implement proper handling of mappings/references after deletes
How do we handle deletes of content that others have mapped/referenced? What happens if an updated source is uploaded after it was deleted?
From_concept = /orgs/CIEL/sources/CIEL/v2021-03-23/concepts/123/
From_concept = /orgs/CIEL/sources/CIEL/concepts/123/139493/

[bmamlin]

@paynejd this is becoming painful for PIH testing (using PIH-temp dictionary isn't ideal) and will become a blocker soon for PIH. I suppose a workaround could be for @snyaggarwal to manually delete the PIH dictionary with each needed update.

[snyaggarwal]

@paynejd @bmamlin current behaviours:

1. On a concept hard delete, its collection references and mappings will stay as is, that means the mappings and references will show the unresolved reference to the deleted concept.
2. Same for source hard delete, its collection references and mappings will stay as-is.

The only rule right now is you cant delete a source/version which has its concepts/mappings referred to in a private collection (public_access=None).

[bmamlin]

The only rule right now is you cant delete a source/version which has its concepts/mappings referred to in a private collection (public_access=None).

Can this be fixed? There are (not unexpectedly) references to PIH from private collections (anyone working on a personal collection with CIEL content could have mappings to PIH), so I still cannot hard delete the PIH source.

[snyaggarwal]

The only rule right now is you cant delete a source/version which has its concepts/mappings referred to in a private collection (public_access=None).

Can this be fixed? There are (not unexpectedly) references to PIH from private collections (anyone working on a personal collection with CIEL content could have mappings to PIH), so I still cannot hard delete the PIH source.

@paynejd This feature was added recently because of #103. Now I think we have references and mappings that may exist even if their referred content doesn't. So is it ok if we revert this?

[paynejd]

Hi @sny, can you say more what you mean by revert this? We definitely want to support references and mappings that point to content that doesn't exist in OCL. We also want to be able to delete content that has references and mappings that point to it.

…

On Thu, Nov 11, 2021 at 10:46 AM Sny ***@***.***> wrote: The only rule right now is you cant delete a source/version which has its concepts/mappings referred to in a private collection (public_access=None). Can this be fixed? There are (not unexpectedly) references to PIH from private collections (anyone working on a personal collection with CIEL content could have mappings to PIH), so I still cannot hard delete the PIH source. @paynejd <https://github.com/paynejd> This feature was added recently because of #103 <#103>. Now I think we have references and mappings that may exist even if their referred content doesn't. So is it ok if we revert this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#661 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJCOOLBR3PWFHFLRFD4U2TULPQMZANCNFSM4ZVF6DYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[snyaggarwal]

I meant should we revert #103 ?

[paynejd]

For now, we agreed to revert #103, which means that we will be able to delete a source that has content that is mapped/referenced by other resources, regardless of whether it is public or private. This will make it so that the behavior for public/private resource links are consistent.

However, a concept/mapping that is referenced in a collection will be removed from existing collection versions, even though the reference will still remain. As part of the upcoming dynamic reference/expansion work, we are planning to save certain attributes from concepts/mappings that have been evaluated in an expansion, so that we'll retain the info that a concept/mapping was part of the expansion, but the user will no longer be able to follow that concept/mapping reference to lookup all of the remaining details.

Need a new ticket for this.

[bmamlin]

Hey @snyaggarwal ... any ETA when this might be available on staging?

[snyaggarwal]

@bmamlin Its available on all environments

[bmamlin]

@bmamlin Its available on all environments

Thanks @snyaggarwal. When I'm logged in as ocladmin on staging looking at /orgs/PIH/sources/PIH/, click the trash can, and type "PIH" to confirm deletion, the browser makes the request DELETE https://api.staging.openconceptlab.org/orgs/PIH/sources/PIH/. This runs for a minute and then returns a 502 error with this brief toast appearing in the UI:

This is the same behavior I've been seeing. Is it supposed to work through the UI? It looks like it's making the same RESTful DELETE call that I'd be making manually anyway.

[snyaggarwal]

@bmamlin the UI is trying to do synchronous delete which is causing timeout due to the size of source. This needs to be fixed.
Meanwhile, you can try async delete by adding ?async=true to the DELETE request and it should queue it for async delete.

[snyaggarwal]

Created ticket for this #1128

[snyaggarwal]

closing this as #1128 is more latest