-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mappings pane in a concept details page #991
Comments
@snyaggarwal I reviewed these and put edits into the checklist above where applicable. A few more small changes, and we can close this one out. |
@paynejd @jamlung-ri I will work on the remaining points. |
@paynejd @jamlung-ri In order to show hierarchy in associations, should we show both children and parents (as the inverse)? |
I think we should be showing both children and parents, but we should be labeling them like that and not using any inverse. It should look something like this if the source has no hierarchy_meaning:
And if there is a hierarchy meaning, then we can use the inverse notation:
|
Agree with Joe -- just please include the source.hierarchy_meaning in the
relationship as well. Something like this:
Has child
(Is a -1)
Has parent
(Is a)
…On Tue, Oct 5, 2021 at 9:42 AM Joseph Amlung ***@***.***> wrote:
I think we should be showing both children and parents, but we should be
labeling them like that and not using any inverse. It should look something
like this:
Relationship Code Name Source
Has Child LP33231-9 Maternal cell contamination (LP33231-9) LOINC
LP192128-9 Cancer risk assessment (LP192128-9) LOINC
LP36464-3 Microsatellite instability (LP36464-3) LOINC
LP76383-6 Identity testing | Comparison case | Index case (LP76383-6)
LOINC
LP62970-6 X linked heterotaxy | Blood or Tissue (LP62970-6) LOINC
Has parent LP29693-6 Laboratory Categories (LP29693-6) LOINC
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#991 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCOOJNHM732ZUIB3LOT4DUFL6EDANCNFSM5EURK5HQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Done |
…ren/parents can be asked separately
… if no mappings or hierarchy
Awesome! Looks good in QA, looking at this ICD concept. |
This should be the new default view on the concept details page -- this should be available to all by default without any configuration.
Requirements:
-1
superscript, or it could just be a label ofInverse
)The text was updated successfully, but these errors were encountered: