Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mappings pane in a concept details page #991

Closed
7 tasks done
paynejd opened this issue Sep 23, 2021 · 7 comments
Closed
7 tasks done

Update mappings pane in a concept details page #991

paynejd opened this issue Sep 23, 2021 · 7 comments
Assignees

Comments

@paynejd
Copy link
Member

paynejd commented Sep 23, 2021

This should be the new default view on the concept details page -- this should be available to all by default without any configuration.

Requirements:

  • Rename to "Associations"
  • include the count of associations to the right of the header
  • include hierarchical relationships in the list using the map_type defined by the source
    • Edit: Looking at this ICD test concept, I am not seeing the hierarchy in there.
  • combine "direct" and "inverse" mappings into the same section -- use an icon after the map_type to indicate that it is inverse (eg "inverse" in math is a -1 superscript, or it could just be a label of Inverse)
  • sort mappings by internal/external (where internal means pointing to a concept in the same source), then by map_type, then by direct/inverse
  • group mappings by map_type + direct/inverse and only show the map_type + direct/inverse once -- no need to repeat it for each row
  • Action icon (the 3-dots) should only appear on mouseover
    • Edit: I believe we decided not to do this, although it may be good to reduce the size of the dots.

image.png

image.png

image.png

@jamlung-ri
Copy link
Contributor

@snyaggarwal I reviewed these and put edits into the checklist above where applicable. A few more small changes, and we can close this one out.

@snyaggarwal
Copy link
Contributor

@paynejd @jamlung-ri I will work on the remaining points.
Just on the hierarchy -- if you want to see the hierarchy attributes you will have to ask for it using query params:
includeParentConceptURLs=true, includeChildConceptURLs=true, includeParentConcepts=true, includeChildConcepts=true, includeHierarchyPath=true

@snyaggarwal
Copy link
Contributor

@paynejd @jamlung-ri In order to show hierarchy in associations, should we show both children and parents (as the inverse)?

snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Oct 4, 2021
@jamlung-ri
Copy link
Contributor

jamlung-ri commented Oct 5, 2021

I think we should be showing both children and parents, but we should be labeling them like that and not using any inverse. It should look something like this if the source has no hierarchy_meaning:

Relationship Code Name Source
Has Child LP33231-9 Maternal cell contamination (LP33231-9) LOINC
LP192128-9 Cancer risk assessment (LP192128-9) LOINC
LP36464-3 Microsatellite instability (LP36464-3) LOINC
LP76383-6 Identity testing | Comparison case | Index case (LP76383-6) LOINC
LP62970-6 X linked heterotaxy | Blood or Tissue (LP62970-6) LOINC
Has parent LP29693-6 Laboratory Categories (LP29693-6) LOINC

And if there is a hierarchy meaning, then we can use the inverse notation:

Relationship Code Name Source
is-a LP33231-9 Maternal cell contamination (LP33231-9) LOINC
LP192128-9 Cancer risk assessment (LP192128-9) LOINC
LP36464-3 Microsatellite instability (LP36464-3) LOINC
LP76383-6 Identity testing | Comparison case | Index case (LP76383-6) LOINC
LP62970-6 X linked heterotaxy | Blood or Tissue (LP62970-6) LOINC
is-a -1 LP29693-6 Laboratory Categories (LP29693-6) LOINC

@paynejd
Copy link
Member Author

paynejd commented Oct 5, 2021 via email

snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
@snyaggarwal
Copy link
Contributor

Done

snyaggarwal added a commit to OpenConceptLab/oclapi2 that referenced this issue Oct 6, 2021
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
@jamlung-ri
Copy link
Contributor

Awesome! Looks good in QA, looking at this ICD concept.

snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
snyaggarwal added a commit to OpenConceptLab/oclweb2 that referenced this issue Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants