Expansion/Dynamic Reference testing

[jamlung-ri]

Once @snyaggarwal has given us a demonstration on the Expansions within the new environment, we need to do some testing to feel out what all it can do.

We should be able to Create old and new-style collections and collection versions.

Follow-up from #818

[jamlung-ri]

Some testing was done in a call yesterday. Sunny has since made changes to the UI to accommodate the issues we noticed. Testing will continue in the next sprint.

[jamlung-ri]

UI feedback has been incorporated, so @paynejd and @jamlung-ri need to continue testing.

[jamlung-ri]

Some expansion testing has occurred as a result of the DDCC content import testing. A couple of videos of issues or potential behavior changes have been posted in the ocl-dev Slack channel.

[jamlung-ri]

@snyaggarwal I did a demonstration of the expansion functions in the Dev environment (before any code merging occurred), and I ran into some difficulties with trying to include retired concepts in the expansion. Can you take a look and let me know if I'm doing this wrong?

• Video 1: https://drive.google.com/file/d/11ila_TM9oRls1FHPmlveL_ekmwY1MxDy/view?usp=sharing
• Video 2: https://drive.google.com/file/d/11st4PWvJrdauueKSiyO-FPF_iUL-qas3/view?usp=sharing

As a follow-up, I tried to create a new reference that had "includeRetired=true" in it but that would not allow any concepts to resolve correctly. Link to the collection and the underlying source.

[snyaggarwal]

That looked like a bug. Will fix this

[snyaggarwal]

@jamlung-ri this is fixed and deployed on QA.
This would mean if you create an expansion where the version has a reference with ?includeRetried it should get retired concepts in the expansion

[jamlung-ri]

Awesome, I was able to get that working to add a retired concept! I discovered another bug in the meantime, however.

• When I try to Add a reference via URL, it starts to bring up the "Add Mappings?" prompt, which quickly disappears. Then I have to click Add again, and it works properly. This might be because OCL runs the background query for "Found XX results with this expression". Quick video example: https://www.loom.com/share/47d54948e99040afa9bc1f160dd35099
• This issue still appears to be present too, related to the UI breaking when searching within the "Find a Source/Collection" option: https://drive.google.com/file/d/11st4PWvJrdauueKSiyO-FPF_iUL-qas3/view?usp=sharing

[snyaggarwal]

@jamlung-ri these both should be fixed on QA

[paynejd]

Final QA testing for this was blocked due to receiving inconsistent results on the MOH IMAP import/export test. We discussed this on the 2/1/2022 Dev call, and @snyaggarwal determined that a postgres connection issue was at the bottom of it. This issue is a result of the infrastructure configuration (e.g. resources available) for the QA/dev environments.

@snyaggarwal to resolve so that we can finish the MOH Alignment tests in QA before moving this functionality on to staging.

[paynejd]

Testing for IMAP/MOH is complete in staging!

@paynejd to finalize testing of the OpenMRS Dictionary Manager this sprint.

[paynejd]

Found a potential issue with migration of collections to the new model on QA -- see here that the HEAD collection version has 44 references but v1.0 collection version has 0 references:
https://app.qa.openconceptlab.org/#/orgs/PEPFAR-Test10b/collections/MER_REFERENCE_INDICATORS_FY19/v1.0/expansions/autoexpand-v1.0/versions

The same is true for many other collections on QA in the PEPFAR-Test10b organization-- see MER_REFERENCE_INDICATORS_FY17 and MER_REFERENCE_INDICATORS_FY18 also.

[snyaggarwal]

@paynejd I suspect v1.0 of MER_REFERENCE_INDICATORS_FY19 was create before the references were added to HEAD.
I created a test version on this and the references were copied correctly. (I deleted that version)
The migration from the old style to the new style doesn't touch references, so it can't be that.