Skip to content

Commit

Permalink
Errbit | Bulk create of mapping/concept via POST is not allowed
Browse files Browse the repository at this point in the history
  • Loading branch information
snyaggarwal committed Jul 21, 2022
1 parent 847cf11 commit 2050826
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions core/concepts/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from core.bundles.serializers import BundleSerializer
from core.common.constants import (
HEAD, INCLUDE_INVERSE_MAPPINGS_PARAM, INCLUDE_RETIRED_PARAM, ACCESS_TYPE_NONE)
from core.common.exceptions import Http400
from core.common.mixins import ListWithHeadersMixin, ConceptDictionaryMixin
from core.common.swagger_parameters import (
q_param, limit_param, sort_desc_param, page_param, exact_match_param, sort_asc_param, verbose_param,
Expand Down Expand Up @@ -171,6 +172,8 @@ def post(self, request, **_):
if not self.parent_resource:
raise Http404()
concept_id = request.data.get('id') or generate_temp_version()
if isinstance(request.data, list):
raise Http400()
serializer = self.get_serializer(
data={**request.data, 'parent_id': self.parent_resource.id, 'id': concept_id, 'name': concept_id}
)
Expand Down
3 changes: 3 additions & 0 deletions core/mappings/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from rest_framework.response import Response

from core.common.constants import HEAD, ACCESS_TYPE_NONE
from core.common.exceptions import Http400
from core.common.mixins import ListWithHeadersMixin, ConceptDictionaryMixin
from core.common.swagger_parameters import (
q_param, limit_param, sort_desc_param, page_param, exact_match_param, sort_asc_param, verbose_param,
Expand Down Expand Up @@ -118,6 +119,8 @@ def post(self, request, **kwargs): # pylint: disable=unused-argument
if not self.parent_resource:
raise Http404()
data = request.data.dict() if isinstance(request.data, QueryDict) else request.data
if isinstance(data, list):
raise Http400()
serializer = self.get_serializer(data={
**data, 'parent_id': self.parent_resource.id
})
Expand Down

0 comments on commit 2050826

Please sign in to comment.