source/collection version export get request returns 208 if its still…

… processing
OpenConceptLab · Feb 4, 2021 · 4304e23 · 4304e23
1 parent 17c7365
commit 4304e23
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 0 deletions.
diff --git a/core/common/mixins.py b/core/common/mixins.py
@@ -499,6 +499,9 @@ def get(self, request, *args, **kwargs):  # pylint: disable=unused-argument
         if version.is_head:
             return Response(status=status.HTTP_405_METHOD_NOT_ALLOWED)
 
+        if version.is_processing:
+            return Response(status=status.HTTP_208_ALREADY_REPORTED)
+
         exists = S3.exists(version.export_path)
 
         if not exists:

diff --git a/core/integration_tests/tests_collections.py b/core/integration_tests/tests_collections.py
@@ -817,6 +817,20 @@ def test_get_204(self, s3_exists_mock):
         self.assertEqual(response.status_code, 204)
         s3_exists_mock.assert_called_once_with("username/coll_v1.{}.zip".format(self.v1_updated_at))
 
+    @patch('core.common.services.S3.exists')
+    def test_get_208(self, s3_exists_mock):
+        self.collection_v1._background_process_ids = ['blah']  # pylint: disable=protected-access
+        self.collection_v1.save()
+
+        response = self.client.get(
+            '/collections/coll/v1/export/',
+            HTTP_AUTHORIZATION='Token ' + self.token,
+            format='json'
+        )
+
+        self.assertEqual(response.status_code, 208)
+        s3_exists_mock.assert_not_called()
+
     @patch('core.common.services.S3.url_for')
     @patch('core.common.services.S3.exists')
     def test_get_303(self, s3_exists_mock, s3_url_for_mock):

diff --git a/core/integration_tests/tests_sources.py b/core/integration_tests/tests_sources.py
@@ -560,6 +560,20 @@ def test_get_204(self, s3_exists_mock):
         self.assertEqual(response.status_code, 204)
         s3_exists_mock.assert_called_once_with("username/source1_v1.{}.zip".format(self.v1_updated_at))
 
+    @patch('core.common.services.S3.exists')
+    def test_get_208(self, s3_exists_mock):
+        self.source_v1._background_process_ids = ['blah']  # pylint: disable=protected-access
+        self.source_v1.save()
+
+        response = self.client.get(
+            '/sources/source1/v1/export/',
+            HTTP_AUTHORIZATION='Token ' + self.token,
+            format='json'
+        )
+
+        self.assertEqual(response.status_code, 208)
+        s3_exists_mock.assert_not_called()
+
     @patch('core.common.services.S3.url_for')
     @patch('core.common.services.S3.exists')
     def test_get_303(self, s3_exists_mock, s3_url_for_mock):