OpenConceptLab/ocl_issues#1501 | fixing pylint errors

OpenConceptLab · Jul 24, 2023 · affa12b · affa12b
1 parent cc54e61
commit affa12b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/core/importers/input_parsers.py b/core/importers/input_parsers.py
@@ -63,6 +63,7 @@ def fetch_file_from_url(self):
             return requests.get(self.file_url, headers=headers, stream=True, timeout=30)
         except Exception as e:
             self.errors.append(f'Failed to download file from {self.file_url}, Exception: {e}.')
+        return None
 
     def set_file_from_response(self, response):
         if get(response, 'ok'):

diff --git a/core/importers/models.py b/core/importers/models.py
@@ -1057,7 +1057,7 @@ def json_result(self):
                     for key in total_result:
                         if result:
                             total_result[key] += result.get(key)
-                except:
+                except:  # pylint: disable=bare-except
                     pass
 
         total_result['start_time'] = self.start_time_formatted

diff --git a/core/importers/tests.py b/core/importers/tests.py
@@ -1,12 +1,11 @@
-import io
 import json
 import os
 import uuid
 from json import JSONDecodeError
 from zipfile import ZipFile
 
 from celery_once import AlreadyQueued
-from django.core.files.uploadedfile import SimpleUploadedFile, InMemoryUploadedFile
+from django.core.files.uploadedfile import SimpleUploadedFile
 from django.core.management import call_command
 from django.db.models import F
 from mock import patch, Mock, ANY, call, PropertyMock
@@ -1705,8 +1704,8 @@ def test_parse_csv_file(self):
                  'owner': 'DemoOrg',
                  'owner_type': 'Organization',
                  'source': 'MyDemoSource',
-                 'from_concept_url': '/orgs/DemoOrg/sources/MyDemoSource/concepts//orgs/DemoOrg/sources/MyDemoSource/concepts/Child_of_child//',
-                 'to_concept_url': '/orgs/DemoOrg/sources/MyDemoSource/concepts//orgs/DemoOrg/sources/MyDemoSource/concepts/Child//'
+                 'from_concept_url': '/orgs/DemoOrg/sources/MyDemoSource/concepts//orgs/DemoOrg/sources/MyDemoSource/concepts/Child_of_child//',  # pylint: disable=line-too-long
+                 'to_concept_url': '/orgs/DemoOrg/sources/MyDemoSource/concepts//orgs/DemoOrg/sources/MyDemoSource/concepts/Child//'  # pylint: disable=line-too-long
              }, {
                  'type': 'Mapping',
                  'map_type': 'Parent-child',
@@ -1761,5 +1760,3 @@ def test_parse_zip_file_url(self, requests_get_mock, zipfile_mock):
         self.assertEqual(parser1.content, parser.content)
         requests_get_mock.assert_called_once_with(
             'https://file.zip', headers={'User-Agent': 'OCL'}, stream=True, timeout=30)
-
-